feat(sdk): Add executionStartTimestamp to InvocationBaseInfo#719
Merged
Conversation
SilanHe
force-pushed
the
feat/add-execution-start-timestamp
branch
from
July 14, 2026 23:51
080c630 to
0bc8ae3
Compare
SilanHe
changed the title
SilanHe
marked this pull request as ready for review
July 15, 2026 16:48
ParidelPooya
previously approved these changes
Jul 15, 2026
ParidelPooya
left a comment
ParidelPooya
left a comment
Contributor
There was a problem hiding this comment.
Untested happy path — the only test touching the real with-durable-execution.ts code path asserts executionStartTimestamp: undefined in both cases. The branch where a real timestamp gets set is never exercised end-to-end; other updated tests just hardcode the field on manually-built fixtures.
Add optional executionStartTimestamp field to InvocationBaseInfo so it is available on all onInvocation* hook parameters (InvocationInfo and InvocationEndInfo). The timestamp is derived from initialExecutionEvent.StartTimestamp when available. Updated all test fixtures constructing InvocationInfo or InvocationEndInfo to include the new field.
SilanHe
force-pushed
the
feat/add-execution-start-timestamp
branch
from
July 15, 2026 17:12
0bc8ae3 to
d64a45c
Compare
ParidelPooya
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Add optional executionStartTimestamp field to InvocationBaseInfo so it is available on all onInvocation* hook parameters (InvocationInfo and InvocationEndInfo). The timestamp is derived from
initialExecutionEvent.StartTimestamp when available (should always be available).
Updated all test fixtures constructing InvocationInfo or InvocationEndInfo to include the new field.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.